Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): add interactive mode for notification #6703

Merged
merged 1 commit into from
Feb 12, 2024
Merged

feat(core): add interactive mode for notification #6703

merged 1 commit into from
Feb 12, 2024

Conversation

splincode
Copy link
Member

@splincode splincode commented Feb 7, 2024 •
edited
Loading

image image image image image

@lumberjack-bot lumberjack-bot
Copy link

lumberjack-bot bot commented Feb 7, 2024 •
edited
Loading

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@splincode splincode force-pushed the splincode/notification branch from db0da39 to 0b98519 Compare February 7, 2024 07:26
@splincode splincode added the v3 label Feb 7, 2024
@bundlemon BundleMon
Copy link

bundlemon bot commented Feb 7, 2024 •
edited
Loading

BundleMon

Files added (5)
Status Path Size Limits
✅ demo/browser/main.(hash).js
 +384.04KB +10%
✅ demo/browser/vendor.(hash).js
 +213.01KB +10%
✅ demo/browser/runtime.(hash).js
 +40.54KB +10%
✅ demo/browser/polyfills.(hash).js
 +11.25KB +10%
✅ demo/browser/styles.(hash).css
 +1.39KB +10%

Total files change +650.23KB

Groups added (1)
Status Path Size Limits
✅ demo/browser/*..js
 +2.35MB -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 7, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit d1d45ac):

https://taiga-ui--pr6703-splincode-notificati-ussx71x9.web.app

(expires Tue, 13 Feb 2024 08:10:07 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@splincode splincode force-pushed the splincode/notification branch from 0b98519 to 9162566 Compare February 7, 2024 07:32
@codecov Codecov
Copy link

codecov bot commented Feb 7, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (v3.x@1a148e2). Click here to learn what that means.

Additional details and impacted files 
@@           Coverage Diff           @@
##             v3.x    #6703   +/-   ##
=======================================
  Coverage        ?   70.58%           
=======================================
  Files           ?     1097           
  Lines           ?    13090           
  Branches        ?     1850           
=======================================
  Hits            ?     9240           
  Misses          ?     3539           
  Partials        ?      311
Flag Coverage Δ
addon-charts 71.46% <0.00%> (?)
addon-doc 60.58% <0.00%> (?)
addon-mobile 60.63% <0.00%> (?)
addon-table 60.75% <0.00%> (?)
addon-tablebars 96.15% <0.00%> (?)
cdk ∅ <0.00%> (?)
core 77.94% <0.00%> (?)
kit 70.28% <0.00%> (?)
summary 70.58% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@splincode splincode force-pushed the splincode/notification branch 2 times, most recently from 58541ef to 40a2594 Compare February 7, 2024 14:52
@splincode splincode changed the title feat(core): add right icon into notification feat(core): add interactive mode Feb 7, 2024
@splincode splincode changed the title feat(core): add interactive mode feat(core): add interactive mode for notification Feb 7, 2024
@splincode splincode force-pushed the splincode/notification branch from 40a2594 to 9a1ea9f Compare February 7, 2024 14:56
@splincode splincode force-pushed the splincode/notification branch 2 times, most recently from 89677bc to 0b6ce87 Compare February 8, 2024 08:27
@splincode splincode force-pushed the splincode/notification branch from 0b6ce87 to d1d45ac Compare February 12, 2024 08:07
@splincode splincode merged commit b0841d3 into v3.x Feb 12, 2024
33 of 34 checks passed
@splincode splincode deleted the splincode/notification branch February 12, 2024 13:39
@taiga-family-bot taiga-family-bot mentioned this pull request Feb 12, 2024
Merged
This was referenced Feb 20, 2024
Merged
Merged
@taiga-family-bot taiga-family-bot mentioned this pull request Mar 4, 2024
Merged
@taiga-family-bot taiga-family-bot mentioned this pull request Mar 12, 2024
Merged
This was referenced Mar 19, 2024
Merged
Merged
This was referenced Apr 2, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladimirpotekhin vladimirpotekhin vladimirpotekhin approved these changes

@waterplea waterplea waterplea approved these changes

@MarsiBarsi MarsiBarsi Awaiting requested review from MarsiBarsi MarsiBarsi is a code owner

@nsbarsukov nsbarsukov Awaiting requested review from nsbarsukov nsbarsukov is a code owner

Assignees

@splincode splincode

Labels
ready to merge v3
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@splincode @waterplea @vladimirpotekhin